[Openpvrsgx-devgroup] [PATCH] staging: pvr: Add a simplified pvr-drv.c as replacement for messy pvr_drm.c

H. Nikolaus Schaller hns at goldelico.com
Fri Nov 8 08:30:54 CET 2019


Hi Tony,

> Am 07.11.2019 um 17:55 schrieb Tony Lindgren <tony at atomide.com>:
> 
> 
>>> So now we could remove the old files to avoid confusion:
>>> 
>>> drivers/staging/pvr/1.14.3699939/eurasia_km/services4/srvkm/env/linux/pvr_drm.c
>>> drivers/staging/pvr/1.14.3699939/eurasia_km/services4/srvkm/env/linux/module.c

removing them and removing services4/srvkm/env/linux/module.o from the Makefile seems to lead to build errors for a clean make:

  Building modules, stage 2.
  MODPOST 666 modules - due to target is PHONY
WARNING: modpost: missing MODULE_LICENSE() in drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap3_sgx530_121.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap3630_sgx530_125.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_am3517_sgx530_125.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_am3352_sgx530_125.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap4_sgx540_120.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap4_sgx544_112.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_am43xx_sgx544_112.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap5_sgx544_116.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_am57xx_sgx544_116.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_dra7_sgx544_116.o
see include/linux/module.h for more information
ERROR: "PVRSRVOpen" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_dra7_sgx544_116.ko] undefined!
ERROR: "gui32ReleasePID" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_dra7_sgx544_116.ko] undefined!
ERROR: "PVRCore_Init" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_dra7_sgx544_116.ko] undefined!
ERROR: "PVRSRVDriverShutdown" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_dra7_sgx544_116.ko] undefined!
ERROR: "PVRSRVDriverResume" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_dra7_sgx544_116.ko] undefined!
ERROR: "PVRCore_Cleanup" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_dra7_sgx544_116.ko] undefined!
ERROR: "gPVRSRVLock" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_dra7_sgx544_116.ko] undefined!
ERROR: "PVRSRVDriverSuspend" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_dra7_sgx544_116.ko] undefined!
ERROR: "PVRSRVOpen" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_am57xx_sgx544_116.ko] undefined!
ERROR: "gui32ReleasePID" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_am57xx_sgx544_116.ko] undefined!
ERROR: "PVRCore_Init" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_am57xx_sgx544_116.ko] undefined!
ERROR: "PVRSRVDriverShutdown" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_am57xx_sgx544_116.ko] undefined!
ERROR: "PVRSRVDriverResume" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_am57xx_sgx544_116.ko] undefined!
ERROR: "PVRCore_Cleanup" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_am57xx_sgx544_116.ko] undefined!
ERROR: "gPVRSRVLock" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_am57xx_sgx544_116.ko] undefined!
ERROR: "PVRSRVDriverSuspend" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_am57xx_sgx544_116.ko] undefined!
ERROR: "PVRSRVOpen" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap5_sgx544_116.ko] undefined!
ERROR: "gui32ReleasePID" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap5_sgx544_116.ko] undefined!
ERROR: "PVRCore_Init" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap5_sgx544_116.ko] undefined!
ERROR: "PVRSRVDriverShutdown" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap5_sgx544_116.ko] undefined!
ERROR: "PVRSRVDriverResume" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap5_sgx544_116.ko] undefined!
ERROR: "PVRCore_Cleanup" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap5_sgx544_116.ko] undefined!
ERROR: "gPVRSRVLock" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap5_sgx544_116.ko] undefined!
ERROR: "PVRSRVDriverSuspend" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap5_sgx544_116.ko] undefined!
ERROR: "PVRSRVOpen" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_am43xx_sgx544_112.ko] undefined!
ERROR: "gui32ReleasePID" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_am43xx_sgx544_112.ko] undefined!
ERROR: "PVRCore_Init" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_am43xx_sgx544_112.ko] undefined!
ERROR: "PVRSRVDriverShutdown" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_am43xx_sgx544_112.ko] undefined!
ERROR: "PVRSRVDriverResume" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_am43xx_sgx544_112.ko] undefined!
ERROR: "PVRCore_Cleanup" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_am43xx_sgx544_112.ko] undefined!
ERROR: "gPVRSRVLock" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_am43xx_sgx544_112.ko] undefined!
ERROR: "PVRSRVDriverSuspend" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_am43xx_sgx544_112.ko] undefined!
ERROR: "PVRSRVOpen" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap4_sgx544_112.ko] undefined!
ERROR: "gui32ReleasePID" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap4_sgx544_112.ko] undefined!
ERROR: "PVRCore_Init" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap4_sgx544_112.ko] undefined!
ERROR: "PVRSRVDriverShutdown" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap4_sgx544_112.ko] undefined!
ERROR: "PVRSRVDriverResume" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap4_sgx544_112.ko] undefined!
ERROR: "PVRCore_Cleanup" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap4_sgx544_112.ko] undefined!
ERROR: "gPVRSRVLock" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap4_sgx544_112.ko] undefined!
ERROR: "PVRSRVDriverSuspend" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap4_sgx544_112.ko] undefined!
ERROR: "PVRSRVOpen" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap4_sgx540_120.ko] undefined!
ERROR: "gui32ReleasePID" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap4_sgx540_120.ko] undefined!
ERROR: "PVRCore_Init" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap4_sgx540_120.ko] undefined!
ERROR: "PVRSRVDriverShutdown" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap4_sgx540_120.ko] undefined!
ERROR: "PVRSRVDriverResume" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap4_sgx540_120.ko] undefined!
ERROR: "PVRCore_Cleanup" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap4_sgx540_120.ko] undefined!
ERROR: "gPVRSRVLock" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap4_sgx540_120.ko] undefined!
ERROR: "PVRSRVDriverSuspend" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap4_sgx540_120.ko] undefined!
ERROR: "PVRSRVOpen" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_am3352_sgx530_125.ko] undefined!
ERROR: "gui32ReleasePID" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_am3352_sgx530_125.ko] undefined!
ERROR: "PVRCore_Init" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_am3352_sgx530_125.ko] undefined!
ERROR: "PVRSRVDriverShutdown" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_am3352_sgx530_125.ko] undefined!
ERROR: "PVRSRVDriverResume" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_am3352_sgx530_125.ko] undefined!
ERROR: "PVRCore_Cleanup" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_am3352_sgx530_125.ko] undefined!
ERROR: "gPVRSRVLock" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_am3352_sgx530_125.ko] undefined!
ERROR: "PVRSRVDriverSuspend" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_am3352_sgx530_125.ko] undefined!
ERROR: "PVRSRVOpen" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_am3517_sgx530_125.ko] undefined!
ERROR: "gui32ReleasePID" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_am3517_sgx530_125.ko] undefined!
ERROR: "PVRCore_Init" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_am3517_sgx530_125.ko] undefined!
ERROR: "PVRSRVDriverShutdown" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_am3517_sgx530_125.ko] undefined!
ERROR: "PVRSRVDriverResume" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_am3517_sgx530_125.ko] undefined!
ERROR: "PVRCore_Cleanup" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_am3517_sgx530_125.ko] undefined!
ERROR: "gPVRSRVLock" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_am3517_sgx530_125.ko] undefined!
ERROR: "PVRSRVDriverSuspend" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_am3517_sgx530_125.ko] undefined!
ERROR: "PVRSRVOpen" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap3630_sgx530_125.ko] undefined!
ERROR: "gui32ReleasePID" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap3630_sgx530_125.ko] undefined!
ERROR: "PVRCore_Init" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap3630_sgx530_125.ko] undefined!
ERROR: "PVRSRVDriverShutdown" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap3630_sgx530_125.ko] undefined!
ERROR: "PVRSRVDriverResume" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap3630_sgx530_125.ko] undefined!
ERROR: "PVRCore_Cleanup" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap3630_sgx530_125.ko] undefined!
ERROR: "gPVRSRVLock" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap3630_sgx530_125.ko] undefined!
ERROR: "PVRSRVDriverSuspend" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap3630_sgx530_125.ko] undefined!
ERROR: "PVRSRVOpen" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap3_sgx530_121.ko] undefined!
ERROR: "gui32ReleasePID" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap3_sgx530_121.ko] undefined!
ERROR: "PVRCore_Init" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap3_sgx530_121.ko] undefined!
ERROR: "PVRSRVDriverShutdown" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap3_sgx530_121.ko] undefined!
ERROR: "PVRSRVDriverResume" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap3_sgx530_121.ko] undefined!
ERROR: "PVRCore_Cleanup" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap3_sgx530_121.ko] undefined!
ERROR: "gPVRSRVLock" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap3_sgx530_121.ko] undefined!
ERROR: "PVRSRVDriverSuspend" [drivers/staging/pvr/1.14.3699939/eurasia_km/pvrsrvkm_omap3_sgx530_121.ko] undefined!
make[3]: *** [__modpost] Error 1
make[2]: *** [modules] Error 2
make[1]: *** [__build_one_by_one] Error 2
make: *** [sub-make] Error 2

I haven't digged into the code what is missing.

Maybe we need to export something? Or the Makefile does not properly handle

$(TARGET) += \
	../../pvr-drv.o \

for modules?

BTW: another candidate for removal could be:

drivers/staging/pvr/1.14.3699939//eurasia_km/services4/srvkm/env/linux/pvr_drm.h

but it is used in more places:

drivers/staging/pvr/1.14.3699939//eurasia_km/services4/3rdparty/dc_nohw/dc_nohw_linux.c:#include "pvr_drm.h"
drivers/staging/pvr/1.14.3699939//eurasia_km/services4/3rdparty/dc_omapfb3_linux/omaplfb_linux.c:#include "pvr_drm.h"
drivers/staging/pvr/1.14.3699939//eurasia_km/services4/3rdparty/dc_poulsbo/poulsbo_linux.c:#include "pvr_drm.h"
drivers/staging/pvr/1.14.3699939//eurasia_km/services4/3rdparty/dc_sunxi/dc_sunxi_displayclass.c:#include "pvr_drm.h"
drivers/staging/pvr/1.14.3699939//eurasia_km/services4/3rdparty/pvr_pdp/pvrpdp_linux.c:#include "pvr_drm.h"
drivers/staging/pvr/1.14.3699939//eurasia_km/services4/srvkm/env/linux/mmap.c:#include "pvr_drm.h"
drivers/staging/pvr/1.14.3699939//eurasia_km/services4/srvkm/env/linux/module.c:#include "pvr_drm.h"
drivers/staging/pvr/1.14.3699939//eurasia_km/services4/srvkm/env/linux/pvr_bridge_k.c:#include "pvr_drm.h"
drivers/staging/pvr/1.14.3699939//eurasia_km/services4/system/omap/sysutils_linux.c:#include "pvr_drm.h"
drivers/staging/pvr/1.14.3699939//eurasia_km/tools/intern/debug/dbgdriv/linux/main.c:#include "pvr_drm.h"

BR,
Nikolaus



More information about the openpvrsgx-devgroup mailing list