[Openpvrsgx-devgroup] [PATCH] staging: pvr: Fix fallthrough compile warning

H. Nikolaus Schaller hns at goldelico.com
Mon Nov 11 09:50:27 CET 2019


> Am 10.11.2019 um 21:01 schrieb Tony Lindgren <tony at atomide.com>:
> 
> Fix warning: this statement may fall through
> 
> Signed-off-by: Tony Lindgren <tony at atomide.com>
> ---
> .../1.14.3699939/eurasia_km/services4/srvkm/common/devicemem.c   | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/pvr/1.14.3699939/eurasia_km/services4/srvkm/common/devicemem.c b/drivers/staging/pvr/1.14.3699939/eurasia_km/services4/srvkm/common/devicemem.c
> --- a/drivers/staging/pvr/1.14.3699939/eurasia_km/services4/srvkm/common/devicemem.c
> +++ b/drivers/staging/pvr/1.14.3699939/eurasia_km/services4/srvkm/common/devicemem.c
> @@ -1071,6 +1071,7 @@ PVRSRV_ERROR FreeMemCallBackCommon(PVRSRV_KERNEL_MEM_INFO *psMemInfo,
> 			case PVRSRV_MEMTYPE_ION:
> 			case PVRSRV_MEMTYPE_DMABUF:
> 				freeExternal(psMemInfo);
> +				/* Fall through */

Yes, modern compiler is checking that...

> 			case PVRSRV_MEMTYPE_DEVICE:
> 			case PVRSRV_MEMTYPE_DEVICECLASS:
> #if defined(SUPPORT_ION)
> -- 
> 2.23.0

picked for new release.

BR and thanks,
Nikolaus



More information about the openpvrsgx-devgroup mailing list