[Openpvrsgx-devgroup] [PATCH] pvrsgx: Fix resource leak

Tony Lindgren tony at atomide.com
Wed Jun 10 16:57:42 CEST 2020


* David Shah <dave at ds0.me> [200610 14:06]:
> A missing call to PVRSRVRelease means that dmabufs are leaked by the
> driver, particularly if applications aren't closed properly. This was
> particularly noticeable with TILER due to the limited TILER space and
> current 8192-wide allocations.

Sorry for missing this part, I was mostly playing with ddk-1.9 that
proxies all the ioctls via omapdrm so it has a slightly different
release path.

Looks like for the ddk-1.9 droid4 related patches I needed a similar
release for omapdrm set with plugin.release = pvr_omap4_release. It
gets called by omapdrm in that case. Just FYI, does not affect this
patch.

Thanks for fixing the issue, this patch looks good to me:

Acked-by: Tony Lindgren <tony at atomide.com>


More information about the openpvrsgx-devgroup mailing list