[Openpvrsgx-devgroup] [PATCH] pvrsgx: Fix resource leak

Dr. H. Nikolaus Schaller hns at goldelico.com
Wed Jun 10 19:09:02 CEST 2020


Looks Good to me as well. I will pick up asap into the repos.

On The Road

> Am 10.06.2020 um 16:58 schrieb Tony Lindgren <tony at atomide.com>:
> 
> * David Shah <dave at ds0.me> [200610 14:06]:
>> A missing call to PVRSRVRelease means that dmabufs are leaked by the
>> driver, particularly if applications aren't closed properly. This was
>> particularly noticeable with TILER due to the limited TILER space and
>> current 8192-wide allocations.
> 
> Sorry for missing this part, I was mostly playing with ddk-1.9 that
> proxies all the ioctls via omapdrm so it has a slightly different
> release path.
> 
> Looks like for the ddk-1.9 droid4 related patches I needed a similar
> release for omapdrm set with plugin.release = pvr_omap4_release. It
> gets called by omapdrm in that case. Just FYI, does not affect this
> patch.
> 
> Thanks for fixing the issue, this patch looks good to me:
> 
> Acked-by: Tony Lindgren <tony at atomide.com>
> _______________________________________________
> https://github.com/openpvrsgx-devgroup/linux_openpvrsgx
> openpvrsgx-devgroup mailing list
> openpvrsgx-devgroup at letux.org
> http://lists.goldelico.com/mailman/listinfo.cgi/openpvrsgx-devgroup
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.goldelico.com/pipermail/openpvrsgx-devgroup/attachments/20200610/3a9fbc91/attachment.htm>


More information about the openpvrsgx-devgroup mailing list